Eli Mesika has posted comments on this change. Change subject: core[Enum]: Adding external status enum ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40992/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java: Line 7: Ok(0), > Unassiged might play a good role if nothing is set. Ok may be leading as th External status should be Ok by design Line 13: HashMap > Use EnumMap instead of hash map. Can't be , it maps enum to its integer value .... -- To view, visit https://gerrit.ovirt.org/40992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46af5206938025ad3c487cc1998b32301783cbf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
