Moti Asayag has posted comments on this change. Change subject: core[Enum]: Adding external status enum ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40992/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalStatus.java: Line 12: HashMap please reduce type to Map. Line 9: Error(3), Line 10: Failure(4); Line 11: Line 12: private static final HashMap<Integer, ExternalStatus> mappings = new HashMap<Integer, ExternalStatus>(); Line 13: private int intValue; a/intValue/id ? Line 14: Line 15: static { Line 16: for (ExternalStatus status : values()) { Line 17: mappings.put(status.getValue(), status); -- To view, visit https://gerrit.ovirt.org/40992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46af5206938025ad3c487cc1998b32301783cbf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
