Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 56: (2 comments) https://gerrit.ovirt.org/#/c/36119/56/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOSessionListener.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOSessionListener.java: Line 12: Line 13: @Override Line 14: public void sessionCreated(HttpSessionEvent se) { Line 15: String sso_token = SSOUtils.generateSsoToken(); Line 16: se.getSession().setAttribute(SSOUtils.SSO_TOKEN, sso_token); are you sure we need to create sso token in each session? maybe we do not want to? I understand that when we destroying a session we clear the sso state as well if session is attached, but why always create sso token? Line 17: ((Map<String, Map>) se.getSession().getServletContext().getAttribute(SSOUtils.SSO_SESSION_DATA)).put(sso_token, new HashMap<String, Object>()); Line 18: ((Map<String, HttpSession>) se.getSession().getServletContext().getAttribute(SSOUtils.SSO_SESSIONS)).put(sso_token, se.getSession()); Line 19: } Line 20: Line 14: public void sessionCreated(HttpSessionEvent se) { Line 15: String sso_token = SSOUtils.generateSsoToken(); Line 16: se.getSession().setAttribute(SSOUtils.SSO_TOKEN, sso_token); Line 17: ((Map<String, Map>) se.getSession().getServletContext().getAttribute(SSOUtils.SSO_SESSION_DATA)).put(sso_token, new HashMap<String, Object>()); Line 18: ((Map<String, HttpSession>) se.getSession().getServletContext().getAttribute(SSOUtils.SSO_SESSIONS)).put(sso_token, se.getSession()); why not put the session object into the above map? Line 19: } Line 20: Line 21: @Override Line 22: public void sessionDestroyed(HttpSessionEvent se) { -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
