Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 59: (3 comments) https://gerrit.ovirt.org/#/c/36119/59/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOServiceBatchServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOServiceBatchServlet.java: Line 214: Line 215: private static String getSsoToken(HttpServletRequest request) { Line 216: String ssoToken = request.getParameter("sso_token"); Line 217: if (StringUtils.isEmpty(ssoToken)) { Line 218: ssoToken = request.getHeader("sso_token"); OVIRT-SSO-TOKEN Line 219: } Line 220: if (StringUtils.isEmpty(ssoToken)) { Line 221: ssoToken = SSOUtils.getSsoTokenForRequestId(request.getServletContext(), request.getParameter("request_id")); Line 222: } Line 218: ssoToken = request.getHeader("sso_token"); Line 219: } Line 220: if (StringUtils.isEmpty(ssoToken)) { Line 221: ssoToken = SSOUtils.getSsoTokenForRequestId(request.getServletContext(), request.getParameter("request_id")); Line 222: } I do not understand how getSsoToken() relates to the request id... probably need to be different fnction. getSsoToken(request) getRequestId(request) getSsoTokenForRequestId(requestId) Line 223: if (StringUtils.isEmpty(ssoToken)) { Line 224: ssoToken = SSOUtils.getSsoTokenForRequestId(request.getServletContext(), request.getHeader("request_id")); Line 225: } Line 226: return ssoToken; https://gerrit.ovirt.org/#/c/36119/59/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java: Line 279: put(requestId, (String) request.getSession(true).getAttribute(SSOUtils.SSO_TOKEN)); Line 280: } Line 281: } Line 282: Line 283: public static void removeRequestIdFromContext(ServletContext ctx, String requestId) { I did not follow... but we should probably perform house keeping these, for example, remove all these that are older than X minutes. this will enable us to deal with always growing data. Line 284: if (StringUtils.isNotEmpty(requestId)) { Line 285: ((Map<String, String>) ctx.getAttribute(SSOUtils.REQUEST_ID_TO_TOKEN_MAP)).remove(requestId); Line 286: } Line 287: } -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 59 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
