Shahar Havivi has posted comments on this change.
Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767)
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 84: if (isoVersion != null &&
isIsoVersionSupported(isoVersion)) {
Line 85: if (isoData.getSupportedClusterVersion()
!= null) {
Line 86: for (String v :
isoData.getSupportedClusterVersion()) {
Line 87: Version isoClusterVersion = new
Version();
Line 88: isoClusterVersion.setValue(v);
Done
Line 89: if
(supportedClusterVersion(isoClusterVersion)) {
Line 90: shouldAdd = true;
Line 91: }
Line 92: }
Line 86: for (String v :
isoData.getSupportedClusterVersion()) {
Line 87: Version isoClusterVersion = new
Version();
Line 88: isoClusterVersion.setValue(v);
Line 89: if
(supportedClusterVersion(isoClusterVersion)) {
Line 90: shouldAdd = true;
Done
Line 91: }
Line 92: }
Line 93: } else if (vdsOsVersion != null) {
Line 94: if
(VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion)) {
Line 116: Collections.sort(availableISOsList);
Line 117: getQueryReturnValue().setReturnValue(availableISOsList);
Line 118: }
Line 119:
Line 120: private boolean supportedClusterVersion(Version
isoClusterVersion) {
Done
Line 121: VDS vds = getVdsByVdsId(getParameters().getVdsId());
Line 122: Version vdsClusterVersion =
vds.getvds_group_compatibility_version();
Line 123: return (vdsClusterVersion.getMajor() ==
isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <=
isoClusterVersion.getMinor());
Line 124: }
Line 119:
Line 120: private boolean supportedClusterVersion(Version
isoClusterVersion) {
Line 121: VDS vds = getVdsByVdsId(getParameters().getVdsId());
Line 122: Version vdsClusterVersion =
vds.getvds_group_compatibility_version();
Line 123: return (vdsClusterVersion.getMajor() ==
isoClusterVersion.getMajor() && vdsClusterVersion.getMinor() <=
isoClusterVersion.getMinor());
yes,
this is for a new minor version with the same major version
Line 124: }
Line 125:
Line 126: private RpmVersion getOvirtOsVersion() {
Line 127: VDS vds = getVdsByVdsId(getParameters().getVdsId());
....................................................
Commit Message
Line 7: Engine: Rhev-H upgrade list show downgraded versions (#842767)
Line 8:
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=842767
Line 10:
Line 11: file /usr/share/rhev-hypervisor/version-X.X-xxxxxxx.x.txt
yes,
in the /usr/share/rhev-hypervisor path we have .iso and its matching .txt files
Line 12: added a clusters version supported (comma separated).
Line 13: the iso for upgrading will be added to the list of available update
Line 14: version according to this value.
Line 15:
--
To view, visit http://gerrit.ovirt.org/7430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
