Alon Bar-Lev has posted comments on this change. Change subject: core: Add support for WildFly ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/40152/9/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 688: # Line 689: # This change can be reverted as soon as we start to use Line 690: # WildFly version that includes a fix for [1]. Line 691: # Line 692: # [1] https://issues.jboss.org/browse/WFLY-4382 > I found out that it's only a comment not to use links for those jars, so IM can we stop the IMO? this is a hack and should be easy to remove if not required using a simple patch, example for eap. commenting it out from main logic was not what you have been requested, so in any case you will get a comment in review. as we have seen in the overlay packaging and other cases, you do not accept comments, do the IMO and then someone else need to redo the work. Line 693: Line 694: # Needed for compatibility if package is different than the directory structure Line 695: %if "%{name}" != "%{engine_name}" Line 696: ln -s "%{engine_name}" "%{buildroot}%{engine_java}/../%{name}" -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
