Alon Bar-Lev has posted comments on this change. Change subject: core: Add support for WildFly ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/40152/9/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 43: %global EXTRA_BUILD_FLAGS %{?_ovirt_build_extra_flags:%{_ovirt_build_extra_flags}}%{?ovirt_build_extra_flags: %{ovirt_build_extra_flags}} Line 44: %endif Line 45: Line 46: %global ovirt_provides_jboss 1 Line 47: %global jboss ovirt-engine-wildfly >= 8.2.0 no need for >= as there is no less. please leave this with disto specific section so we can easily revert that for fedora when it will provide jboss leaving it for all other arch. Line 48: Line 49: %if 0%{?fedora} Line 50: %global ovirt_install_systemd 1 Line 51: %global ovirt_install_systemv 0 Line 688: # Line 689: # This change can be reverted as soon as we start to use Line 690: # WildFly version that includes a fix for [1]. Line 691: # Line 692: # [1] https://issues.jboss.org/browse/WFLY-4382 I explicitly asked to place a section before the "backward compatibility" to revert the symlink, why have you done this deferentially? Line 693: Line 694: # Needed for compatibility if package is different than the directory structure Line 695: %if "%{name}" != "%{engine_name}" Line 696: ln -s "%{engine_name}" "%{buildroot}%{engine_java}/../%{name}" Line 876: cat > "%{buildroot}%{engine_etc}/engine.conf.d/20-setup-jboss-overlay.conf" << __EOF__ Line 877: ENGINE_JAVA_MODULEPATH="/usr/share/ovirt-engine-wildfly-overlay/modules:\${ENGINE_JAVA_MODULEPATH}" Line 878: __EOF__ Line 879: %endif Line 880: extra space is not needed. Line 881: Line 882: # Line 883: # bakcward compatibility Line 884: # keep ovirt-engine-setup package to pull ovirt-engine-setup-plugin-ovirt-engine -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
