Omer Frenkel has posted comments on this change.
Change subject: <restapi>: WipeAfterDelete defaults to true in GUI, but false
in REST API.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java
Line 13: static Boolean wipeAfterDeleteBlockStorageDomain;
Line 14:
Line 15: static boolean wipeAfterDeleteFileStorageDomain = false;
Line 16:
Line 17: public static synchronized boolean
getDefaultWipeAfterDeleteFlag(final StorageType storageType) {
sorry i don't understand what is sync'ed here and why
Line 18: if(storageType.isBlockDomain()) {
Line 19: if(wipeAfterDeleteBlockStorageDomain == null) {
Line 20: wipeAfterDeleteBlockStorageDomain =
Line 21:
Config.<Boolean>GetValue(ConfigValues.SANWipeAfterDelete);
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-15 17:41:37 +0200
Line 4: Commit: Ravi Nori <rn...@redhat.com>
Line 5: CommitDate: 2012-10-15 17:44:59 +0200
Line 6:
Line 7: <restapi>: WipeAfterDelete defaults to true in GUI, but false in REST
API.
actually better change to 'core' as changes are not in restapi at all
Line 8:
Line 9: WipeAfterDelete in gui default to false for File Storage Domains and
for Block storage domains the value is defined by SANWipeAfterDelete'
configuration value. The backend logic has been changed to mimic this behaviour.
Line 10:
Line 11: Change-Id: I1aeeb7d30a604e1647446021e3a96f35f3b4e2b7
--
To view, visit http://gerrit.ovirt.org/8570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aeeb7d30a604e1647446021e3a96f35f3b4e2b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
