Michael Pasternak has posted comments on this change. Change subject: <restapi>: WipeAfterDelete defaults to true in GUI, but false in REST API. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java Line 13: static Boolean wipeAfterDeleteBlockStorageDomain; Line 14: Line 15: static boolean wipeAfterDeleteFileStorageDomain = false; Line 16: Line 17: public static synchronized boolean getDefaultWipeAfterDeleteFlag(final StorageType storageType) { Omer, it's storageType sync, not lazy-init of wipeAfterDeleteBlockStorageDomain. Line 18: if(storageType.isBlockDomain()) { Line 19: if(wipeAfterDeleteBlockStorageDomain == null) { Line 20: wipeAfterDeleteBlockStorageDomain = Line 21: Config.<Boolean>GetValue(ConfigValues.SANWipeAfterDelete); -- To view, visit http://gerrit.ovirt.org/8570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aeeb7d30a604e1647446021e3a96f35f3b4e2b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches