Martin Mucha has posted comments on this change. Change subject: core: Introduce HostSetupNetworksParameters parameters ......................................................................
Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/32776/20/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java: Line 19: /*This field currently cannot be validated via bean validation due to validation conflict: Line 20: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 21: conflicting validations. So {@link NetworkAttachment} will be validated manually in Line 22: {@link org.ovirt.engine.core.bll.CommandBase#canDoAction}*/ Line 23: private List<NetworkAttachment> networkAttachments; > As I wrote in the next comment, I don't see any reason for passing the whol used Guid where possible, changed List to Set for those fields, @Valid still not possible. Done. Line 24: Line 25: Line 26: /*This field currently cannot be validated via bean validation due to validation conflict: Line 27: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 26: /*This field currently cannot be validated via bean validation due to validation conflict: Line 27: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 28: conflicting validations. So {@link NetworkAttachment} will be validated manually in Line 29: {@link org.ovirt.engine.core.bll.CommandBase#canDoAction}*/ Line 30: private List<NetworkAttachment> removedNetworkAttachments; > this should be related to vdsm, for HostSetupNetworksVDSCommand we pass the Done Line 31: Line 32: private List<Bond> bonds; Line 33: Line 34: private List<Bond> removedBonds; Line 30: private List<NetworkAttachment> removedNetworkAttachments; Line 31: Line 32: private List<Bond> bonds; Line 33: Line 34: private List<Bond> removedBonds; > it can be name or id, which identifies the bond. Done Line 35: Line 36: private boolean rollbackOnFailure = true; Line 37: Line 38: @ConfiguredRange(min = 1, maxConfigValue = ConfigValues.NetworkConnectivityCheckTimeoutInSeconds, -- To view, visit https://gerrit.ovirt.org/32776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If353c08a8db257333d7696df0c7c887d179bc41a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
