Martin Mucha has posted comments on this change. Change subject: core: Introduce HostSetupNetworksParameters parameters ......................................................................
Patch Set 22: (3 comments) https://gerrit.ovirt.org/#/c/32776/22/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java: Line 15: public class HostSetupNetworksParameters extends VdsActionParameters { Line 16: Line 17: private static final long serialVersionUID = 6819278948636850828L; Line 18: Line 19: // TODO @NoRepetitiveStaticIpInList(message = "VALIDATION.REPETITIVE.IP.IN.VDS") > I don't understand this TODO, can you please remove it from here and add it Done Line 20: Line 21: /*This field currently cannot be validated via bean validation due to validation conflict: Line 22: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 23: conflicting validations. So {@link NetworkAttachment} will be validated manually in Line 17: private static final long serialVersionUID = 6819278948636850828L; Line 18: Line 19: // TODO @NoRepetitiveStaticIpInList(message = "VALIDATION.REPETITIVE.IP.IN.VDS") Line 20: Line 21: /*This field currently cannot be validated via bean validation due to validation conflict: > Please remove that currently. It sounds like a temporary situation that is Done Line 22: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 23: conflicting validations. So {@link NetworkAttachment} will be validated manually in Line 24: {@link org.ovirt.engine.core.bll.CommandBase#canDoAction}*/ Line 25: private List<NetworkAttachment> networkAttachments; Line 24: {@link org.ovirt.engine.core.bll.CommandBase#canDoAction}*/ Line 25: private List<NetworkAttachment> networkAttachments; Line 26: Line 27: Line 28: /*This field currently cannot be validated via bean validation due to validation conflict: > This comment isn't relevant anymore. true. But this whole won't be validated, so I'm not adding any bean validation annotation here. Done. Line 29: {@link NetworkAttachment} in this class is present as new entity and entity to be removed, both requiring different Line 30: conflicting validations. So {@link NetworkAttachment} will be validated manually in Line 31: {@link org.ovirt.engine.core.bll.CommandBase#canDoAction}*/ Line 32: private Set<Guid> removedNetworkAttachments; -- To view, visit https://gerrit.ovirt.org/32776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If353c08a8db257333d7696df0c7c887d179bc41a Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
