Moti Asayag has posted comments on this change. Change subject: webadmin: Introduce a column for additional host statuses ......................................................................
Patch Set 7: (1 comment) in addition to applying the comments, also moved the icon image and its declaration to the this patch. https://gerrit.ovirt.org/#/c/40635/7/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostAdditionalStatusCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostAdditionalStatusCell.java: Line 27: ImageResource statusImage = resources.updateAvailableImage(); Line 28: // Generate the HTML for the image: Line 29: SafeHtml statusImageHtml = Line 30: SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(statusImage).getHTML()); Line 31: sb.append(statusImageHtml); > Line 31 is redundant. i wonder how it worked :) Line 32: Line 33: templates.hostAdditionalStatusIcon(id, statusImageHtml); Line 34: } -- To view, visit https://gerrit.ovirt.org/40635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5797668b9875b5b4b90aa4dfb992b5cd15ccdb2c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
