Alona Kaplan has posted comments on this change. Change subject: webadmin: Introduce a column for additional host statuses ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/40635/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostAdditionalStatusCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostAdditionalStatusCell.java: Line 26: Line 27: // Generate the HTML for the image: Line 28: SafeHtml statusImageHtml = Line 29: SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(statusImage).getHTML()); Line 30: sb.append(statusImageHtml); Please use ApplicationTemplates instead of constructing the SafeHtml. Line 31: Line 32: sb.appendHtmlConstant("<div id=\"" + id + "\" style=\"text-align: center;\">"); //$NON-NLS-1$ //$NON-NLS-2$ Line 33: sb.appendHtmlConstant("</div>"); //$NON-NLS-1$ Line 34: } https://gerrit.ovirt.org/#/c/40635/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java: Line 23: if (object instanceof VDS){ Line 24: return (VDS) object; Line 25: } Line 26: Line 27: if (object instanceof PairQueryable){ Why do you need this? Are you planning to add the column to SubTabNetworkHostView? Line 28: if (((PairQueryable<?, ?>) object).getSecond() instanceof VDS) { Line 29: return (VDS) ((PairQueryable<?, ?>) object).getSecond(); Line 30: } Line 31: } -- To view, visit https://gerrit.ovirt.org/40635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5797668b9875b5b4b90aa4dfb992b5cd15ccdb2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
