Omer Frenkel has posted comments on this change. Change subject: engine:cannot start stateless VM ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java Line 306: CreateAllSnapshotsFromVmParameters tempVar = new CreateAllSnapshotsFromVmParameters(getVm().getId(), Line 307: "stateless snapshot"); Line 308: tempVar.setShouldBeLogged(false); Line 309: tempVar.setParentCommand(getActionType()); Line 310: tempVar.setParentParameters(getParameters()); sorry, i didn't understand, runVmCommand starts CreateAllSnapshotsFromVmCommand, and 'tells' it which is his parent (runVm..) so why this is redundent? if it will not be set, runVmCommand's end action will not be called, and then.. mess, no? Line 311: tempVar.setEntityId(getParameters().getEntityId()); Line 312: CreateAllSnapshotsFromVmParameters p = tempVar; Line 313: p.setSnapshotType(SnapshotType.STATELESS); Line 314: -- To view, visit http://gerrit.ovirt.org/8461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6152049360dd0254b9bd07b2397abd9d7d56c5d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
