Sahina Bose has posted comments on this change. Change subject: gluster: Mount the gluster meta volume on the nodes ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40688/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 967: > volume list syncing happens every 5 secs, and mounting work every 5 secs wo But you would need to mount only when a new volume is detected if you add this in the createvolume flow...no need to check for existence of meta volume and mount every 5 minutes https://gerrit.ovirt.org/#/c/40688/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/MountGlusterMetaVolumeVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/MountGlusterMetaVolumeVDSCommand.java: Line 12: status > The VDSM verb does not take input param as meta volume name. The name is st Then what's the point of having the meta volume name configurable at the engine side? Shouldn't the vdsm verb be changed to take this as a parameter? -- To view, visit https://gerrit.ovirt.org/40688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74199eac5c1b7f0f8bec8ad78b2f417a8fc5960a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
