Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Mount the gluster meta volume on the nodes ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/40688/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 409: } Line 410: return glusterHostUuidFound && initGlusterPeerProcess() && mountGlusterMetaVolume(); Line 411: } Line 412: Line 413: private boolean mountGlusterMetaVolume() { > Shouldn't this done only if meta-volume exists? Done Line 414: VDSReturnValue retVal = Line 415: runVdsCommand(VDSCommandType.MountGlusterMetaVolume, new VdsIdVDSCommandParametersBase(getVdsId())); Line 416: Line 417: // If mounting failed, just log error and continue https://gerrit.ovirt.org/#/c/40688/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 967: > shouldn't this be done when a new volume is detected - i.e in the createVol volume list syncing happens every 5 secs, and mounting work every 5 secs would be too heavy so thought of keeping as part of heavyweight syncing. https://gerrit.ovirt.org/#/c/40688/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/MountGlusterMetaVolumeVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/MountGlusterMetaVolumeVDSCommand.java: Line 12: status > Shouldn't the name of the meta-volume be a parameter to vdsm? The VDSM verb does not take input param as meta volume name. The name is standard and its hard coded in VDSM side. -- To view, visit https://gerrit.ovirt.org/40688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74199eac5c1b7f0f8bec8ad78b2f417a8fc5960a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
