Moti Asayag has posted comments on this change.

Change subject: engine: Schedule a job for monitoring host's updates
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/40460/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java:

Line 2150:      */
Line 2151:     @TypeConverterAttribute(List.class)
Line 2152:     @DefaultValueAttribute("")
Line 2153:     @OptionBehaviourAttribute(behaviour = 
OptionBehaviour.CommaSeparatedStringArray)
Line 2154:     UserPackageNamesForUpdate,
> why isn't this identical to UserPackageNamesForCheckUpdate ?
Done
Line 2155: 
Line 2156:     /**
Line 2157:      * The interval in hours of checking for available updates on 
the host.
Line 2158:      */


https://gerrit.ovirt.org/#/c/40460/6/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties:

Line 992: CINDER_DISK_CONNECTION_FAILURE=Failed to retrieve connection 
information for Cinder Disk '${DiskAlias}'.
Line 993: CINDER_DISK_CONNECTION_VOLUME_DRIVER_UNSUPPORTED=Unsupported volume 
driver for Cinder Disk '${DiskAlias}'.
Line 994: VM_ADD_HOST_DEVICES=Host devices ${NamesAdded} were attached to Vm 
${VmName} by User ${UserName}.
Line 995: VM_REMOVE_HOST_DEVICES=Host devices ${NamesRemoved} were detached 
from Vm ${VmName} by User ${UserName}.
Line 996: HOST_AVAILABLE_UPDATES_FAILED=Failed to check for available packages 
on host '${VdsName}' with message '${Message}'.
> I'd put "available updates" and not "available packages"
Done


-- 
To view, visit https://gerrit.ovirt.org/40460
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2114d00e626c09cd7b8be1f9a4564a0f3c0ba700
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to