Eli Mesika has posted comments on this change. Change subject: engine: Schedule a job for monitoring host's updates ......................................................................
Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/40460/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 671: USER_REMOVE_VDS_GROUP_FAILED(814, AuditLogSeverity.ERROR), Line 672: MAC_POOL_EMPTY(816, AuditLogSeverity.WARNING), Line 673: MAC_ADDRESS_IS_IN_USE(833, AuditLogSeverity.WARNING), Line 674: MAC_ADDRESS_IS_IN_USE_UNPLUG(838, AuditLogSeverity.WARNING), Line 675: HOST_AVAILABLE_UPDATES_FAILED(839, AuditLogSeverity.ERROR), If this done periodically, maybe we should add here also flood def Line 676: CERTIFICATE_FILE_NOT_FOUND(817, AuditLogSeverity.ERROR), Line 677: RUN_VM_FAILED(818, AuditLogSeverity.ERROR), Line 678: MAC_ADDRESSES_POOL_NOT_INITIALIZED(837, AuditLogSeverity.WARNING, Line 679: AuditLogTimeInterval.HOUR.getValue()), https://gerrit.ovirt.org/#/c/40460/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 154: refreshRate, Line 155: TimeUnit.MILLISECONDS); Line 156: Line 157: double availableUpdatesRefreshRate = Config.<Double> getValue(ConfigValues.HostPackagesUpdateTimeInHours); Line 158: final int HOURS_TO_MINUTES = 60; Can be done with TimeUnit IIRC Line 159: long rateInMinutes = Math.round(availableUpdatesRefreshRate * HOURS_TO_MINUTES); Line 160: Line 161: availableUpdatesJobId = Line 162: sched.scheduleAFixedDelayJob( https://gerrit.ovirt.org/#/c/40460/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 261: select fn_db_add_config_value_for_versions_up_to('MigrationCompressionSupported','false','3.5'); Line 262: Line 263: select fn_db_add_config_value_for_versions_up_to('HostDevicePassthroughSupported','false','3.5'); Line 264: Line 265: select fn_db_add_config_value('PackageNamesForCheckUpdate','vdsm,vdsm-cli','general'); please add a comment new entries purpose Line 266: select fn_db_add_config_value('UserPackageNamesForCheckUpdate','','general'); Line 267: select fn_db_add_config_value('UserPackageNamesForUpdate','','general'); Line 268: select fn_db_add_config_value('HostPackagesUpdateTimeInHours','24','general'); Line 269: https://gerrit.ovirt.org/#/c/40460/2/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 474: BackupCheckPeriodInHours.type=Integer Line 475: BackupAlertPeriodInDays.description="Determines the max number of days allowed without a fresh backup - default : 1 day" Line 476: BackupAlertPeriodInDays.type=Integer Line 477: HostPackagesUpdateTimeInHours.description=Refresh rate (in hours) for available host updates check. Line 478: UserPackageNamesForUpdate.description=A comma separated list of packages to be upgraded by the host upgrade action. consider also mergable to allow easy update of this value Line 479: UserPackageNamesForUpdate.type=StringMultiple Line 480: UserPackageNamesForCheckUpdate.description=A comma separated list of packages to be checked for updates by the host upgrade action. Line 476: BackupAlertPeriodInDays.type=Integer Line 477: HostPackagesUpdateTimeInHours.description=Refresh rate (in hours) for available host updates check. Line 478: UserPackageNamesForUpdate.description=A comma separated list of packages to be upgraded by the host upgrade action. Line 479: UserPackageNamesForUpdate.type=StringMultiple Line 480: UserPackageNamesForCheckUpdate.description=A comma separated list of packages to be checked for updates by the host upgrade action. consider also mergable to allow easy update of this value -- To view, visit https://gerrit.ovirt.org/40460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2114d00e626c09cd7b8be1f9a4564a0f3c0ba700 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
