Moti Asayag has posted comments on this change.
Change subject: core: Adding NetworkIdParameters (WIP)
......................................................................
Patch Set 2: (2 inline comments)
minor comments
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkIdParameters.java
Line 7: /**
Line 8: * The Parameters class for queries that use only Network Id
Line 9: */
Line 10: public class NetworkIdParameters extends VdcQueryParametersBase {
Line 11: private static final long serialVersionUID = -5550670672065955312L;
please add space line before the annotation.
Line 12: @NotNull
Line 13: private Guid networkId;
Line 14:
Line 15: public NetworkIdParameters(Guid networkId) {
Line 18:
Line 19: public Guid getNetworkId() {
Line 20: return networkId;
Line 21: }
Line 22:
please move the c'tor above the getter
Line 23: public NetworkIdParameters() {
Line 24: }
--
To view, visit http://gerrit.ovirt.org/8527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d5e3d2cfc44d80710e28e10db91f07bb1a65428
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
