Mike Kolesnik has posted comments on this change.

Change subject: core: Adding NetworkIdParameters (WIP)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkIdParameters.java
Line 15: 
Line 16:     public Guid getNetworkId() {
Line 17:         return networkId;
Line 18:     }
Line 19: 
GWT requires public default ctor

However, a notnull validation annotation might be a good idea
Line 20:     public NetworkIdParameters() {
Line 21:     }


--
To view, visit http://gerrit.ovirt.org/8527
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d5e3d2cfc44d80710e28e10db91f07bb1a65428
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to