Daniel Erez has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 43: (6 comments) https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 1651: Cannot a single "Cannot ${action} ${type}." is enough :) https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java: Line 1042: saveMostStorageProperties consider renaming to a more specific method name... https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java: Line 44: Line 45: public class StorageModel extends ListModel<IStorageModel> implements ISupportSystemTreeContext Line 46: { Line 47: public static final Guid UnassignedDataCenterId = Guid.Empty; Line 48: please move these constants to some place common - e.g. StorageConstants Line 49: //low space threshold maximum value (%) Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; Line 45: public class StorageModel extends ListModel<IStorageModel> implements ISupportSystemTreeContext Line 46: { Line 47: public static final Guid UnassignedDataCenterId = Guid.Empty; Line 48: Line 49: //low space threshold maximum value (%) add space after '//' Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; Line 53: Line 51: //critical space threshold maximum value (GB) same https://gerrit.ovirt.org/#/c/35277/43/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml: Line 126: formatting -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
