Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: pinting just a warning on NFS restart issue ......................................................................
packaging: setup: pinting just a warning on NFS restart issue For preexisting cause NFS could not be started/restarted. Just print a warning instead of breaking. Change-Id: I1582294d8ef6ae691218adf31d15bf54932b6389 Bug-Url: https://bugzilla.redhat.com/1119225 Signed-off-by: Simone Tiraboschi <stira...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 28 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/40653/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py index 904be5d..28fd32d 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py @@ -282,29 +282,39 @@ def _closeup(self): self.logger.info(_('Restarting nfs services')) - if not self.services.supportsDependency: - self.services.startup( - name='rpcbind', - state=True, - ) - self.services.state( - name='rpcbind', - state=True, - ) + try: + if not self.services.supportsDependency: + self.services.startup( + name='rpcbind', + state=True, + ) + self.services.state( + name='rpcbind', + state=True, + ) - self.services.startup( - name=self.environment[ - oenginecons.SystemEnv.NFS_SERVICE_NAME - ], - state=True, - ) - for state in (False, True): - self.services.state( + self.services.startup( name=self.environment[ oenginecons.SystemEnv.NFS_SERVICE_NAME ], - state=state, + state=True, ) + for state in (False, True): + self.services.state( + name=self.environment[ + oenginecons.SystemEnv.NFS_SERVICE_NAME + ], + state=state, + ) + except RuntimeError as ex: + self.logger.debug('exception', exc_info=True) + msg = _( + 'Unable to start NFS service or its dependencies: {error}\n' + 'Please check their configuration and manually restart' + ).format( + error=ex, + ) + self.logger.warning(msg) # vim: expandtab tabstop=4 shiftwidth=4 -- To view, visit https://gerrit.ovirt.org/40653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1582294d8ef6ae691218adf31d15bf54932b6389 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
