Moti Asayag has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40565/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AsyncCallback.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AsyncCallback.java: Line 1: package org.ovirt.engine.core.common.vdscommands; Line 2: Line 3: public interface AsyncCallback { please add javadoc for this class and to the method. Line 4: public Object process(Object returnValue, VDSAsyncReturnValue value); https://gerrit.ovirt.org/#/c/40565/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSAsyncReturnValue.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSAsyncReturnValue.java: Line 1: package org.ovirt.engine.core.common.vdscommands; Line 2: Line 3: Line 4: public abstract class VDSAsyncReturnValue extends VDSReturnValue { please add javadoc for this class and to the abstract method. Line 5: Line 6: private AsyncCallback callback; Line 7: Line 8: public VDSAsyncReturnValue() { -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
