Oved Ourfali has posted comments on this change. Change subject: vdsbroker: async vdscommand ......................................................................
Patch Set 3: (2 comments) Some comments. Overall I'd imagine something more generic, but I agree with this approach for now. It is indeed cleaner than the other alternatives, and can be merged in a timely manner. Thanks! https://gerrit.ovirt.org/#/c/40565/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java: Line 54: // and we want returnValue clean from last run. Line 55: _returnValue = new VDSReturnValue(); Line 56: getVDSReturnValue().setSucceeded(true); Line 57: if (isAsync()) { Line 58: setAsyncResult(); I wonder whether to call it setAsyncResult, or something different. As it also runs the command. Perhaps we should just call it executeCommandAsynchronously, and in VDSCommandBase we call either the sync or the async one. Line 59: return; Line 60: } Line 61: executeVDSCommand(); Line 62: } catch (RuntimeException ex) { https://gerrit.ovirt.org/#/c/40565/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java: Line 72: String about the try-catch-finally block, don't we need it here as well? -- To view, visit https://gerrit.ovirt.org/40565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c8a05c286a9008ef9a08ac7da02bc7211c4af9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
