Ramesh N has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail ......................................................................
Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/32100/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 290: queryParamsList variable not used Line 323: if(session == null) { : return; : } this check not required as its already handled by action availability. https://gerrit.ovirt.org/#/c/32100/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java: Line 55: @UiField(provided = true) Do u really need to provide all these fields manually? https://gerrit.ovirt.org/#/c/32100/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.ui.xml: Line 29: <g:ScrollPanel addStyleNames="{style.tablePanel}"> : <e:EntityModelCellTable ui:field="geoRepSessionSummaryTable" /> : </g:ScrollPanel> : <g:FlowPanel> : <g:Label ui:field="georepSessionDetailsHeader" addStyleNames="{style.headerLabel}"/> : <ge:EntityModelLabelEditor ui:field="checkPointStatus" /> : <ge:EntityModelLabelEditor ui:field="crawlStatus" /> : <ge:EntityModelLabelEditor ui:field="dataOpsPending" /> : <ge:EntityModelLabelEditor ui:field="metaOpsPending" /> : <ge:EntityModelLabelEditor ui:field="entryOpsPending" /> : <ge:EntityModelLabelEditor ui:field="failures" /> : <ge:EntityModelLabelEditor ui:field="checkPointTime" /> : <ge:EntityModelLabelEditor ui:field="checkPointCompletedAt" /> : </g:FlowPanel> Please align properly. -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
