Shubhendu Tripathi has posted comments on this change. Change subject: engine,webadmin : geo-rep status detail ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/32100/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java: Line 25: if(geoRepSessionDetails == null) { Line 26: continue; Line 27: } Line 28: ArrayList<GlusterGeoRepSessionDetails> currentSessionDetails = (ArrayList<GlusterGeoRepSessionDetails>) geoRepSessionDetails; Line 29: currentSession.setSessionDetails(currentSessionDetails); Why set the value if null check next? Check for null value of currentSessionDetails and if not null then only call currentSession.setSessionDetails and continue further. Line 30: if (currentSession.getSessionDetails() != null) { Line 31: for (GlusterGeoRepSessionDetails currentDetail : currentSession.getSessionDetails()) { Line 32: GlusterBrickEntity currentBrick = Line 33: getGlusterBrickDao().getById(currentDetail.getMasterBrickId()); -- To view, visit https://gerrit.ovirt.org/32100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cc6151fb71a4aa67dc76ec8dd8c93b76796f165 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
