Ramesh N has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/39756/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java: Line 101: hostFeatureDao.getSupportedHostFeaturesByHostId(vds.getId()); Line 102: for (SupportedAdditionalClusterFeature feature : clusterSupportedFeatures) { Line 103: if (feature.isEnabled() && !hostSupportedFeatures.contains(feature.getFeature().getName())) { Line 104: Map<String, String> customLogValues = new HashMap<>(); Line 105: customLogValues.put("{UnSupportedFeature", feature.getFeature().getName()); > why the leading { ? typo ? Thanks Moti. I was searching this for long time but still my eyes could not catch this. Line 106: reportNonOperationReason(NonOperationalReason.HOST_FEATURES_INCOMPATIBILE_WITH_CLUSTER, customLogValues); Line 107: return; Line 108: } Line 109: } https://gerrit.ovirt.org/#/c/39756/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1308: } Line 1309: Line 1310: private static String AssignStringValueFromArray(Map<String, Object> input, String name) { Line 1311: String[] arr = AssignStringArrayValue(input, name); Line 1312: if (arr != null) { > please indent. Done Line 1313: return StringUtils.join(arr, ','); Line 1314: } Line 1315: return null; Line 1316: } -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
