Moti Asayag has posted comments on this change. Change subject: core: backup awareness, full backup check ......................................................................
Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40543/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java: Line 84: } Line 85: } Line 86: Line 87: private void doBackupCheck() { Line 88: AuditLogableBase alert = new AuditLogableBase(); not a big deal and not related to this patch, but if an event shouldn't be logged, the alert was instantiated for nothing. meaning the instantiating of could be move closer to where it is being used. Line 89: Line 90: //try to get last backup record Line 91: EngineBackupLog lastDbBackup = getLastBackupByScope(BackupScope.DB); Line 92: EngineBackupLog lastFilesBackup = getLastBackupByScope(BackupScope.FILES); -- To view, visit https://gerrit.ovirt.org/40543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71a8b2b4278db039518f7bfc9b684f390ca449fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
