Eli Mesika has posted comments on this change. Change subject: core: backup awareness, full backup check ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40543/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java: Line 25: */ Line 26: @Singleton Line 27: public class EngineBackupAwarenessManager { Line 28: Line 29: private enum BACKUP_SCOPE { > Please use BackupScope to behave according to Java Coding Conventions Done Line 30: DB("db"), Line 31: FILES("files"); Line 32: Line 33: String name; Line 100: Date lastFullBackupDate = lastDbBackupDate.compareTo(lastFilesBackupDate) < 0 Line 101: ? Line 102: lastDbBackupDate Line 103: : Line 104: lastFilesBackupDate; > Please reformat: Done Line 105: long diffInDays = (Calendar.getInstance().getTimeInMillis() - lastFullBackupDate.getTime()) Line 106: / TimeUnit.DAYS.toMillis(1); Line 107: if (diffInDays > backupAlertPeriodInDays) { Line 108: alert.addCustomValue("Date", lastFullBackupDate.toString()); -- To view, visit https://gerrit.ovirt.org/40543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71a8b2b4278db039518f7bfc9b684f390ca449fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
