Allon Mureinik has posted comments on this change.
Change subject: core: avoid having SD active on vdsm and not in engine
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
minor comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 36: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 37: public class ReconstructMasterDomainCommand<T extends
ReconstructMasterParameters> extends
Line 38: DeactivateStorageDomainCommand<T> {
Line 39:
Line 40: protected boolean reconstructOpsSucceeded;
I'd have this private with a protected getter and setter, but it's a matter of
taste I guess.
Line 41: /**
Line 42: * Constructor for command creation when compensation is applied
on startup
Line 43: *
Line 44: * @param commandId
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
Line 108: VdcBllErrors.StorageServerConnectionError));
Line 109: }
Line 110: } finally {
Line 111: if (!reconstructOpsSucceeded) {
Line 112:
DbFacade.getInstance().getStoragePoolIsoMapDao().remove(new
StoragePoolIsoMapId(getRecoveryStoragePoolParametersData()
Don't we have a "getStoragePoolIsoMapDao()" method?
Also, the indentation looks a bit funky in gerrit.
Does it look OK in a decent editor?
Line 113: .getNewMasterDomainId(),
getRecoveryStoragePoolParametersData().getStoragePoolId()));
Line 114: }
Line 115: }
Line 116: }
--
To view, visit http://gerrit.ovirt.org/8390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida51b027b8078555ffab5b80d2ffe54572fa6cca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
