Vered Volansky has posted comments on this change.
Change subject: core: avoid having SD active on vdsm and not in engine
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 36: @NonTransactiveCommandAttribute(forceCompensation = true)
Line 37: public class ReconstructMasterDomainCommand<T extends
ReconstructMasterParameters> extends
Line 38: DeactivateStorageDomainCommand<T> {
Line 39:
Line 40: boolean reconstructOpsSucceeded;
Should add modifier
Line 41: /**
Line 42: * Constructor for command creation when compensation is applied
on startup
Line 43: *
Line 44: * @param commandId
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
Line 106: "Failed to connect storage"),
Line 107: VdcBllErrors.StorageServerConnectionError));
Line 108: }
Line 109: } finally {
Line 110: if (!reconstructOpsSucceeded) {
Why not used before?
As I understand it, it was used before either way, and now only if the the
reconstruct succeeded.
Line 111:
getCompensationContext().snapshotNewEntity(domainPoolMap);
Line 112: getCompensationContext().stateChanged();
Line 113: }
Line 114: }
--
To view, visit http://gerrit.ovirt.org/8390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida51b027b8078555ffab5b80d2ffe54572fa6cca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
