Vered Volansky has posted comments on this change. Change subject: core: Add storage space thresholds support ......................................................................
Patch Set 41: (2 comments) https://gerrit.ovirt.org/#/c/35277/41/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java: Line 148: Line 149: private Integer warningLowSpaceIndicator; Line 150: Line 151: public String getWarningLowSpaceIndicator() { Line 152: return warningLowSpaceIndicator == null ? null : warningLowSpaceIndicator.toString(); > God no, this snak in here from a patch on top. Will re-post. Actually, all of this is not in use, removing it all. Line 153: } Line 154: Line 155: public void setWarningLowSpaceIndicator(Integer warningLowSpaceIndicator) { Line 156: if (!ObjectUtils.objectsEqual(this.warningLowSpaceIndicator, warningLowSpaceIndicator)) { https://gerrit.ovirt.org/#/c/35277/41/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java: Line 48: Line 49: //low space threshold maximum value (%) Line 50: private final static short LOW_SPACE_THRESHOLD = 100; Line 51: //critical space threshold maximum value (GB) Line 52: private final static short CRITICAL_SPACE_THRESHOLD = 100; > In any case 100 is arbitrary and makes no sense so either no limit or a con It's been suggested offline with ydary that we leave it for now, as 100, as this is arbitrary just like any other number. Once the tooltip warning is enabled (framework is currently broken, should be fixed soon according to Greg), this limitation will be removed and we'll let the user abuse our system. Are you good with this? Line 53: Line 54: private StorageModelBehavior behavior; Line 55: Line 56: private String localFSPath; -- To view, visit https://gerrit.ovirt.org/35277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82 Gerrit-PatchSet: 41 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
