Tomas Jelinek has posted comments on this change.

Change subject: core: Allow creation of new disks as copy of any existing disk
......................................................................


Patch Set 6:

ok, enriched the check for gluster to disallow also the copy. The error message 
returned to the user looks like this:
"Error while executing action: Cannot copy Virtual Machine Disk. mydiskname is 
shareable, which Gluster domains do not support."
I did not change the constant name itslef since it would generate a bit of 
overhead for the translators. Especially since the message itself was generic 
enough already.

-- 
To view, visit https://gerrit.ovirt.org/38334
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07eece05b1880011f1a1b4300d07f0bd1ebf30bd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to