Tomas Jelinek has posted comments on this change. Change subject: core: Allow creation of new disks as copy of any existing disk ......................................................................
Patch Set 4: > Hi Tomas, thanks for the fixes. > Few questions though, not that we allow copy of disk from a VM, how should we > handle: > 1) shared disk - I assume it will have the same behviour as before It will just create a new disk which will also be sharable. Do you mean that it should be disallowed to copy the sharable disk to glusterfs? > 2) External LUN disk - should we blocked that one? The MoveOrCopyDiskCommand works only with images > 3) OVF_STORE disk Not supported - checked in canDoAction() -> isDiskUsedAsOvfStore() > Also how a disk with snapshots should be copied? If a disk contains snapshots > I guess it will be copied with collapse snapshots (Am I wrong?) yes, in overrideParameters() there is this call: getParameters().setUseCopyCollapse(true); so the VDS command which causes the collapse copy will be called -- To view, visit https://gerrit.ovirt.org/38334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07eece05b1880011f1a1b4300d07f0bd1ebf30bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
