Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/40100/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 2109: NetworkSriovSupported, Line 2110: Line 2111: @TypeConverterAttribute(Boolean.class) Line 2112: @DefaultValueAttribute("true") Line 2113: MigrateDowntime, > since its a boolean a better name should be MigrateDowntimeSupported, with Done Line 2114: Line 2115: Invalid Line 2116: https://gerrit.ovirt.org/#/c/40100/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java: Line 160: CORSSupport, Line 161: CORSAllowedOrigins, Line 162: CinderProviderSupported, Line 163: NetworkSriovSupported, Line 164: MigrateDowntime; > is it needed by the ui? this enum is for exposing configuration values to t yes you right. Line 165: Line 166: public static enum ConfigAuthType { Line 167: Admin, Line 168: User -- To view, visit https://gerrit.ovirt.org/40100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18c6db9a85167b1c4b85bdad22cf63f0204f378 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
