Shahar Havivi has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40100/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 193: } Line 194: } Line 195: Line 196: protected void getDowntime() { Line 197: try { > we should only call this for hosts that support the new downtime value Done Line 198: VDSReturnValue retVal = runVdsCommand(VDSCommandType.MigrateStatus, Line 199: new MigrateStatusVDSCommandParameters(getDestinationVdsId(), getVmId())); Line 200: if (retVal != null) { Line 201: actualDowntime = (Integer) retVal.getReturnValue(); https://gerrit.ovirt.org/#/c/40100/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 285: @Override Line 286: public MigrateStatusReturnForXmlRpc migrateStatus(String vmId) { Line 287: JsonRpcRequest request = new RequestBuilder("VM.getMigrationStatus").withParameter("vmID", vmId).build(); Line 288: Map<String, Object> response = new FutureMap(this.client, request).withResponseKey("response") Line 289: .withResponseType(Long.class); > did you make sure this doesnt break older vdsms? (3.5 is the first version Yes I did check Line 290: return new MigrateStatusReturnForXmlRpc(response); Line 291: } Line 292: Line 293: @Override -- To view, visit https://gerrit.ovirt.org/40100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic18c6db9a85167b1c4b85bdad22cf63f0204f378 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
