Moti Asayag has posted comments on this change. Change subject: core: Add @Vetoed implementation for CDI 1.0 ......................................................................
Patch Set 1: > Currently we need to add @Vetoed only to PostgresDbEngineDialect > class to be able to use WildFly for oVirt 3.6 > > In the next step we should annotate all business entities which > will use JPA as it's recommended approach by [1]. Currently AFAIK > it's only Bookmark and and EngineBackupLog, in future (not sure how > distant) all business entities using JPA should be marked with > @Vetoed. > > It should be noted that even that original weld extension for CDI > 1.0 [2] is still supported on CDI 1.1+, but it's not part of CDI > specification. In CDI 1.1+ there's official way how to exclude > classes from scanning [3]/[4], but it doesn't support regular > expressions but only wildcards. > > Anyway I tested code using weld-scan extension and it seems that it > works with EAP 6.4, WildFly 8.2 and WildFly 9.0CR1. > So we can use it for now instead of @Vetoed, but I would argue to > move to standard extension [3]/[4] once we move to EAP 7 > downstream. > Thanks for the detailed summary. > So do all agree to use weld-scan extension instead of @Vetoed? > +1 > Thanks > > Martin > > [1] Why is @Vetoed a best practice for persistent (JPA) entities? > http://www.cdi-spec.org/faq/#accordion12 > [2] > http://docs.jboss.org/weld/reference/1.1.16.Final/en-US/html_single/#d0e5774 > [3] > https://docs.jboss.org/weld/reference/2.1.2.Final/en-US/html_single/#d0e6114 > [4] > http://docs.jboss.org/weld/reference/latest-2.2/en-US/html_single/#_excluding_classes_from_scanning_and_deployment -- To view, visit https://gerrit.ovirt.org/40458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95aaacbcb2e44e791e540235e3b9f3a4e193dee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
