Martin Peřina has posted comments on this change. Change subject: core: Add @Vetoed implementation for CDI 1.0 ......................................................................
Patch Set 1: Yevgeny, I haven't tried it, I thought we agreed on @Vetoed approach :-) I can look at it, but before I do this just one question: do you think that it's more readable/understandable to mark a class as not initialized by CDI container in beans.xml file or using an annotation? Technically both solutions looks same correct to me, especially when we move to EAP7 downstream and we could remove our own implementation of @Vetoed. IMO using annotation is more readable, but if you think otherwise, I can change it, again :-) Yevgeny, Moti, Oved, what do you think? -- To view, visit https://gerrit.ovirt.org/40458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95aaacbcb2e44e791e540235e3b9f3a4e193dee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
