Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Rework webadmin login sequence
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/38212/11/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
File 
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java:

Line 208:         HttpSession session = request.getSession();
Line 209:         Object value = session.getAttribute(UI_PREFIX + key);
Line 210:         if (value == null) {
Line 211:             value = session.getAttribute(key);
Line 212:         }
push this regardless?
Line 213:         String result = null;
Line 214:         if (value instanceof String) {
Line 215:             result = (String)value;
Line 216:         } else if (value != null) {


-- 
To view, visit https://gerrit.ovirt.org/38212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76ecd389f4938e294d1b3d82f5e1a42eb60d9a20
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to