Alon Bar-Lev has posted comments on this change. Change subject: aaa: Add ability to switch user ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/38146/10/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java: Line 27: public static final String SSO_STORE_TYPE = "ENGINE_PKI_ENGINE_STORE_TYPE"; Line 28: public static final String SSO_STORE_PASSWD = "ENGINE_SSO_ENGINE_STORE_PASSWORD"; Line 29: public static final String SSO_STORE_ALIAS = "ENGINE_SSO_ENGINE_STORE_ALIAS"; Line 30: public static final String ACCEPT_BASIC_AUTH_HEADERS = "SSO_ACCEPT_BASIC_AUTH_HEADERS"; Line 31: public static final String ALLOW_DISABLE_EXTERNAL_AUTH = "SSO_ALLOW_DISABLE_EXTERNAL_AUTH"; shouldn't this go to some previous patch? Line 32: public static final String ENABLE_BASIC_AUTH = "SSO_ENABLE_BASIC_AUTH"; Line 33: public static final String ENABLE_EXTERNAL_AUTH = "SSO_ENABLE_EXTERNAL_AUTH"; Line 34: public static final String ENFORCE_NEGO = "SSO_ENFORCE_NEGO"; Line 35: https://gerrit.ovirt.org/#/c/38146/10/backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml: Line 88: <servlet-name>WelcomeServlet</servlet-name> Line 89: <servlet-class>org.ovirt.engine.core.WelcomeServlet</servlet-class> Line 90: <init-param> Line 91: <param-name>sso-switch-user-url</param-name> Line 92: <param-value>%{SSO_SWITCH_USER_URL}</param-value> I think the prefix of sso is sufficient in configuration, then you can append specific servlet. Line 93: </init-param> Line 94: </servlet> Line 95: Line 96: <servlet-mapping> -- To view, visit https://gerrit.ovirt.org/38146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b40d6ea34372ea9e2c2017d500051e6f135bfb8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
