Dudi Maroshi has posted comments on this change. Change subject: Engine: Scheduling-policy removal error message correction ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/38574/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveClusterPolicyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveClusterPolicyCommand.java: Line 30: Line 31: private StringBuilder clustersListIntoTokenizedString() { Line 32: StringBuilder attachedClustersStringBf = new StringBuilder(""); Line 33: List<VDSGroup> attachedClustersList = Line 34: SchedulingManager.getInstance().getClustersByClusterPolicyId(getParameters().getClusterPolicyId()); > Please use StringUtils.join() in order to create the comma separated list, Done Line 35: boolean isFirstCluster = true; Line 36: for (VDSGroup vdsGroup : attachedClustersList) { Line 37: if (isFirstCluster == false) Line 38: attachedClustersStringBf.append(','); -- To view, visit https://gerrit.ovirt.org/38574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a95c3a973b8ba9053727009983480ce79119f83 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
