Roy Golan has posted comments on this change. Change subject: Engine: Scheduling-policy removal error message correction ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38574/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveClusterPolicyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveClusterPolicyCommand.java: Line 23: StringBuffer you probably meant StringBuilder Line 26: boolean isFirstCluster = true; : for (VDSGroup vdsGroup : attachedClustersList) { : if (isFirstCluster == false) : attachedClustersStringBf.append(','); : : attachedClustersStringBf.append('\'').append(vdsGroup.getName()).append('\''); : isFirstCluster = false; : } you can replace all that with Entities.collectionToString -- To view, visit https://gerrit.ovirt.org/38574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a95c3a973b8ba9053727009983480ce79119f83 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
