Alona Kaplan has posted comments on this change. Change subject: core,webadmin: Add QoS column to Networks main tab ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/37452/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java: Line 81: } Line 82: } else if (!getDataCenterName().equals(other.getDataCenterName())) { Line 83: return false; Line 84: } Line 85: if (Objects.equals(getQosName(), other.getQosName())) { Shouldn't the condition be negative? Line 86: return false; Line 87: } Line 88: if (Objects.equals(getProviderName(), other.getProviderName())) { Line 89: return false; https://gerrit.ovirt.org/#/c/37452/2/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkViewDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkViewDaoTest.java: Line 30: FixturesTool.NETWORK_ENGINE)); Line 31: Line 32: assertFalse(result.isEmpty()); Line 33: assertEquals(FixturesTool.NETWORK_ENGINE, result.get(0).getId()); Line 34: assertNotNull(result.get(0).getQosName()); Please add 'get' tests for networks with and without qos. Line 35: } Line 36: Line 37: /** Line 38: * Ensures the right set of networks are returned for the given provider. -- To view, visit https://gerrit.ovirt.org/37452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9ef4f3ccd38a6806ebbaf1e3970a2b823e916d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
