Alon Bar-Lev has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/40157/9/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java: Line 202: String arg = args.get(argumentIndex); Line 203: if(!arg.startsWith(LONG_PREFIX)) { Line 204: break; Line 205: } Line 206: argumentIndex++; just create a copy of args, and revert the use of index, very difficult now to review diff anyway. what is the advantage of using the index? Line 207: if(arg.equals(LONG_PREFIX)) { Line 208: break; Line 209: } Line 210: Line 300: private void putValue(Map<String, Object> argMap, Argument arg, Object value) { Line 301: if (!arg.isMultivalue()) { Line 302: argMap.put(arg.getName(), value); Line 303: } else { Line 304: List<? super Object> c = (List)argMap.get(arg.getName()); this should be a collection unless a good reason. Line 305: if (c == null) { Line 306: c = new ArrayList<>(); Line 307: argMap.put(arg.getName(), c); Line 308: } -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
