Alon Bar-Lev has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40157/8/backend/manager/modules/uutils/src/main/resources/org/ovirt/engine/core/uutils/cli/parser/defaults.properties File backend/manager/modules/uutils/src/main/resources/org/ovirt/engine/core/uutils/cli/parser/defaults.properties: Line 16: # argument can be specified more times, it will store list of values Line 17: arg.multivalue = false Line 18: # If argument has no value specified this value will be set Line 19: #arg.value = Line 20: # if argument is mandatory and not specified set it's value to arg.default, by default it's none, > why not always take default? difference between default and value: default ddd value vvv for argument in all command line arguments: if argument is required_argument and no value - error if no value set value to vvv for all parameters: set ddd as value if parameter is mandatory and no value - error ondra, please confirm that mandatory behaves this way. Line 21: # so if argument is mandatory and has no default value parsing will fail on IllegalArgumentException Line 22: #arg.default = Line 23: # will be print as first, should contain usage of program/module/action Line 24: help.usage = -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
