Dudi Maroshi has posted comments on this change. Change subject: hosted-engine: hosted-engine client, with storage connection timeout ......................................................................
Patch Set 2: Verified+1 (2 comments) https://gerrit.ovirt.org/#/c/40392/2/ovirt_hosted_engine_ha/broker/listener.py File ovirt_hosted_engine_ha/broker/listener.py: Line 169: DisconnectionError, RuntimeError, DetailedError, \ Line 170: MetadataError, FatalMetadataError, SanlockInitializationError, \ Line 171: BrokerInitializationError, \ Line 172: NotImplementedError, BlockBackendCorruptedException, \ Line 173: IOError, OSError) as e: Circuit breaker exception trap for all applicative errors, we want to report back to the broker's caller. Line 174: response = "failure " + format(str(e)) Line 175: self._log.debug("Response: %s", response) Line 176: util.socket_sendline(self.request, self._log, response) Line 177: except socket.timeout: https://gerrit.ovirt.org/#/c/40392/2/ovirt_hosted_engine_ha/broker/storage_broker.py File ovirt_hosted_engine_ha/broker/storage_broker.py: Line 126: f = os.open(path, direct_flag | os.O_RDONLY) Line 127: os.lseek(f, offset, os.SEEK_SET) Line 128: data = os.read(f, read_size) Line 129: os.close(f) Line 130: except (IOError, OSError) as e: Added OSError trap, to catch mounting errors. The IOError is thrown from the file system. Line 131: self._log.error("Failed to read metadata from %s", Line 132: path, exc_info=True) Line 133: raise RequestError("failed to read metadata: {0}".format(str(e))) Line 134: -- To view, visit https://gerrit.ovirt.org/40392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
