Tal Nisan has posted comments on this change. Change subject: core: Check attached VMs snapshot status when moving a disk ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40080/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 181: } Line 182: return false; Line 183: } Line 184: Line 185: private boolean validateVmSnapshotStatus() { > * not sure it's mandatory as previewing only a sub-set of disks is usually I agree with the comment about the UI, and aside for the fact that it's not easy to block, when the user will see it grayed out in the disks tab without seeing the snapshots tab, he will not know why it's grayed out and in this case it's better to let the user proceed and get a message from the backend Line 186: SnapshotsValidator snapshotsValidator = getSnapshotsValidator(); Line 187: for (Pair<VM, VmDevice> pair : getVmsWithVmDeviceInfoForDiskId()) { Line 188: VmDevice vmDevice = pair.getSecond(); Line 189: if (vmDevice.getSnapshotId() == null) { // Skip check for VMs with connected snapshot -- To view, visit https://gerrit.ovirt.org/40080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
