Ramesh N has posted comments on this change.

Change subject: webadmin: add validation for create brick popup view
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39439/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java:

Line 178: validateMountPoint
> Is it possible to write a regex to validate this instead of having multiple
Regular expression for this validation goes crazy. We have an NFS mount point 
validator but that has following two issues.

1. It allow spaces
2. It allows /*, /../ etc

Can we have it as it is and work on the regular expression later.


-- 
To view, visit https://gerrit.ovirt.org/39439
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to