Kanagaraj M has posted comments on this change. Change subject: webadmin: add validation for create brick popup view ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39439/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/CreateBrickModel.java: Line 157: Line 158: IntegerValidation noOfPhysicalDiscsValidation = new IntegerValidation(); Line 159: noOfPhysicalDiscsValidation.setMinimum(1); Line 160: getNoOfPhysicalDisksInRaidVolume().validateEntity(new IValidation[] { new NotEmptyValidation(), Line 161: noOfPhysicalDiscsValidation }); Missing? noOfPhysicalDiscsValidation().getIsValid() Line 162: Line 163: IntegerValidation stripSizeValidation = new IntegerValidation(); Line 164: stripSizeValidation.setMinimum(1); Line 165: getStripeSize().validateEntity(new IValidation[] { new NotEmptyValidation(), -- To view, visit https://gerrit.ovirt.org/39439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16d3a2c377a80f37b6f8aba061ad26ac17d9736b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
