Ala Hino has posted comments on this change. Change subject: engine: Add support for Refresh LUNs size ......................................................................
Patch Set 8: (8 comments) https://gerrit.ovirt.org/#/c/39318/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java: Line 54: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_REFRESH_LUNS_UNSUPPORTED_ACTION); Line 55: } Line 56: Line 57: if (!(checkStorageDomain() && checkStorageDomainStatus(StorageDomainStatus.Active))) { Line 58: return false; No message here? Line 59: } Line 60: Line 61: if (!getStorageDomain().getStorageType().isBlockDomain()) { Line 62: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL); Line 58: return false; Line 59: } Line 60: Line 61: if (!getStorageDomain().getStorageType().isBlockDomain()) { Line 62: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL); You may also want to use failCanDoAction Line 63: return false; Line 64: } Line 65: Line 66: if (!checkStorageDomainStatusNotEqual(StorageDomainStatus.Locked)) { Line 63: return false; Line 64: } Line 65: Line 66: if (!checkStorageDomainStatusNotEqual(StorageDomainStatus.Locked)) { Line 67: return false; If this condition still valid, do you want to add a msg? Line 68: } Line 69: Line 70: if (!checkLunsInStorageDomain(getParameters().getLunIds(), getStorageDomain())) { Line 71: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_LUNS_NOT_PART_OF_STORAGE_DOMAIN); Line 67: return false; Line 68: } Line 69: Line 70: if (!checkLunsInStorageDomain(getParameters().getLunIds(), getStorageDomain())) { Line 71: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_LUNS_NOT_PART_OF_STORAGE_DOMAIN); Same as before - failCanDoAction Line 72: return false; Line 73: } Line 74: Line 75: return true; Line 77: Line 78: private boolean checkLunsInStorageDomain(ArrayList<String> lunIds, StorageDomain storageDomain) { Line 79: // Get LUNs from DB Line 80: List<LUNs> lunsFromDb = getLunDao().getAll(); Line 81: Set<LUNs> lunsFoundInSD = new HashSet<>(); I see that this list is only used to count number of LUNs founf in SD. Maybe you want to use a simple counter instead of a list holding LUNs just to get list size. Line 82: Guid sdGuid = storageDomain.getId(); Line 83: Line 84: for (LUNs lun : lunsFromDb) { Line 85: if (lunIds.contains(lun.getLUN_id())) { Line 82: Guid sdGuid = storageDomain.getId(); Line 83: Line 84: for (LUNs lun : lunsFromDb) { Line 85: if (lunIds.contains(lun.getLUN_id())) { Line 86: if (sdGuid.equals(lun.getStorageDomainId())) { These if conditions could be combined Line 87: // LUN is part of the storage domain Line 88: lunsFoundInSD.add(lun); Line 89: } Line 90: } Line 177: } Line 178: } Line 179: Line 180: private Map<String, List<VDS>> refreshLunSizeAllVds(List<String> luns) { Line 181: Please remove empty line Line 182: Map<String, LUNs> allLuns = getLuns(); Line 183: Line 184: Map<String, List<VDS>> lunToVds = new HashMap<>(); Line 185: for (String lun : luns) { Line 179: Line 180: private Map<String, List<VDS>> refreshLunSizeAllVds(List<String> luns) { Line 181: Line 182: Map<String, LUNs> allLuns = getLuns(); Line 183: Please remove empty line Line 184: Map<String, List<VDS>> lunToVds = new HashMap<>(); Line 185: for (String lun : luns) { Line 186: int actualSize = getSize(allLuns, lun); Line 187: for (VDS vds : getAllRunningVdssInPool()) { -- To view, visit https://gerrit.ovirt.org/39318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c5c6d59087736466ee5e7eb0c77ee9282199c62 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
